elkozmon / zoonavigator

Web-based ZooKeeper UI / editor / browser
https://zoonavigator.elkozmon.com
GNU Affero General Public License v3.0
506 stars 72 forks source link

Saving a node and trying to navigate outside of it still warns about "Discard changes" #22

Closed sheinbergon closed 4 years ago

sheinbergon commented 6 years ago

After saving the node via the UI text editor clicking on the "home" icon or somewhere else in the node tree issues a warning about discarding unsaved values.

elkozmon commented 4 years ago

This seems to be fixed now.

Redirts commented 4 years ago

No, it is not fixed.

2020-02-03_16-55-04

elkozmon commented 4 years ago

@Redirts Sorry, I failed to mention that I was talking about the latest builds (as in :latest Docker image) since commit bd31f1fb1ca07bd1a7d4c206d323c0eca3cb62d5. There is no stable release of those changes yet.

Which version were you using, please? You can figure that out by opening the menu in the top right corner and clicking Show session info. Thank you!

Redirts commented 4 years ago

ZooNavigator version: latest-83c7683fe661

elkozmon commented 4 years ago

Ok so that is an older release. If you pull the new image now it should work fine, I hope :)

Get Outlook for iOShttps://aka.ms/o0ukef


From: Redirts notifications@github.com Sent: Monday, February 3, 2020 6:34 PM To: elkozmon/zoonavigator Cc: Luboš Kozmon; State change Subject: Re: [elkozmon/zoonavigator] Saving a node and trying to navigate outside of it still warns about "Discard changes" (#22)

ZooNavigator version: latest-83c7683fe661

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/elkozmon/zoonavigator/issues/22?email_source=notifications&email_token=ABFED2HPHQPQIPD34JTTSQDRBBIT3A5CNFSM4FR5TJ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUWYTY#issuecomment-581528655, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABFED2FZEMDXXR7RHER6THDRBBIT3ANCNFSM4FR5TJ5A.

elkozmon commented 4 years ago

Turns out you're right, it's still an issue. I couldn't reproduce it locally on my computer for some reason. Anyway, I'm reopening this then. Sorry.

Redirts commented 4 years ago

Seems ok now but will let you know if it breaks in another use case. Thanks

elkozmon commented 4 years ago

@Redirts Happy to hear that. Sure, let me know. Thank you