search

elkozmon / zoonavigator

Web-based ZooKeeper UI / editor / browser
https://zoonavigator.elkozmon.com
GNU Affero General Public License v3.0
506 stars 72 forks source link

Setting HTTP_PORT=disabled makes docker healthcheck fail #41

Closed sturcol closed 4 years ago

sturcol commented 4 years ago

While running the container with HTTPS only (and using the env vars described at https://www.elkozmon.com/zoonavigator/docker/configuration/) I encountered the docker container reporting a bad healthcheck.

Compose file: version: '2' services: zoonavigator: image: elkozmon/zoonavigator:latest restart: always network_mode: bridge hostname: zoonavigator ports:

Portainer shows the following error: curl: (3) Port number ended with 'd'

It appears the issue lies in the healthcheck.sh file (https://github.com/elkozmon/zoonavigator/blob/master/build/docker/files/zoonavigator-api/healthcheck.sh.template) since it assumes that the HTTP_PORT will always be defined.

elkozmon commented 4 years ago

Hi, thanks for reporting this! If you like, you can submit a PR, otherwise, I'll fix it sometime this week.

elkozmon commented 4 years ago

It should work well now in the new 0.7.1 release. Cheers!

sturcol commented 4 years ago

Works great, thanks for the quick fix.