elky / django-flat-theme

A flat theme for Django admin interface. Modern, fresh, simple.
Other
413 stars 46 forks source link

Change icons to something modern #20

Closed DrJackilD closed 9 years ago

DrJackilD commented 9 years ago

Have a desire to replace the current icons in the interface (with something like Font Awesome). But I see that there is an additional branch with the same purpose. There is a sense in completion, or the author has completed and will soon be merging?

collinanderson commented 9 years ago

see also https://code.djangoproject.com/ticket/20597

elky commented 9 years ago

@DrJackilD @collinanderson can you guys help me to test new icons, please?

I pushed new branch called flat-icons so you can run: pip install git+https://github.com/elky/django-flat-theme.git@flat-icons --upgrade in your test project to see how it works now.

P.S. Code will be refactored a bit later so just check how it works visually.

Thank you.

DrJackilD commented 9 years ago

Sure, will test it today in evening.

DrJackilD commented 9 years ago

@elky OK, I was tested it and find problem. FontAwesome doesn't link to admin's page, because there is wrong path. I was tried to change it, but have no effect (it's probably because I tested it on ready-to-production project, and make manage.py collectstatic before) screenshot - 30 07 2015 - 04 35 38 screenshot - 30 07 2015 - 04 37 43

UPD. Yeah, I'm edited FontAwesome path in font-awesome.css in django-flat-theme folder and all working well now. And that's looking really awesome with FontAwesome :) Great job, man!

elky commented 9 years ago

I'm edited FontAwesome path in font-awesome.css

Oh, I completely forgot that file names are case sensitive in unix. Thanks!

timgraham commented 9 years ago

What's your assessment of the "Icon Font" vs. "Inline SVG" article that Collin linked to on the Django ticket?

elky commented 9 years ago

@timgraham replied there.

elky commented 9 years ago

1.1.0 version is shipped with flat svg icons.