search

ellaisys / aws-cognito

AWS Cognito package (with MFA Feature) using the AWS SDK for PHP/Laravel
https://ellaisys.github.io/aws-cognito/
MIT License
110 stars 41 forks source link

Revert "Update AuthenticatesUsers.php" #15

Closed sunnydesign closed 1 year ago

sunnydesign commented 3 years ago

Hi! I see you has reverts all changes from my pull request. Also, I see that you has merged all my forked repository along with unnecessary changes. But I can send you clean pull request treesome only necessary commits.

amitdhongde commented 3 years ago

You had changed the package name and hence we had to revert the changes. As these are used in the production code, please do not change the package name. You may please send the clean pull request and we will review and implement those.

sunnydesign commented 3 years ago

Yes, the point is that when I send the pull request, the package name was not changed, but I had to change it later in order to plug my fork into my working project. And, accordingly, these changes were added to the pull request that I sent earlier, since at the time of sending it has not yet been accepted by you. I have now sent a pull request to a separate branch. Check it please.

amitdhongde commented 3 years ago

Thank you, Sunny. I'm having this tested along with another fix. Once all is good, we will merge it.

sunnydesign commented 3 years ago

Good!

amitdhongde commented 1 year ago

This change was implemented in Release 25 (tag v1.0.10)