Add toggle so this feature can be disabled per-user

[markjaquith]

This feature is very opinionated. Users might want to disable it. Thankfully, we can do this without any (or much) new UI, as the DFW (full screen) button was already in place. We can use this as a toggle between auto-DFW (which should be default), and no-DFW.

[ellatrix]

What icon should we use? The current one wouldn't make much sense.

[markjaquith]

@melchoyce thoughts?

[ellatrix]

The only icon that it somewhat relevant is this: https://github.com/melchoyce/dashicons/blob/master/svg/smiley.svg

:D

[melchoyce]

Would we be getting rid of DFW entirely if this merges? If so, I'd just reuse that button.

[ellatrix]

Yes, but the icon for that button is not good. We're not toggling fullscreen.

[melchoyce]

But it feels fullscreen, right? Do you think users will care about the difference?

[markjaquith]

Original DFW wasn't really fullscreen either. I'm not sure the distinction matters.

What could we use to indicate toggle state? Make it look dim and inactive when auto DFW is disabled?

[ellatrix]

Okay, let's use the fullscreen icon then. Just use the active buttons styles?

[ellatrix]

Like bold etc.

[melchoyce]

Yeah, I'd just use what's already there.

[michaelbeil]

No smiley? sad day. just tested the dfw/focus toggle, and it doesn't do anything yet.

[ellatrix]

What does it not do? If you toggle it off, does the fading not stop?

[michaelbeil]

It doesn't stop. Focus mode remains on. http://beil.io/1guSD

[ellatrix]

Any JS errors? Are you sure you pulled the latest changes?

[michaelbeil]

No JS errors. And I believe so. I pull again.

[ellatrix]

Did it work?

[michaelbeil]

Not quite yet @avryl. will check again tomorrow via other browsers.