search

ellatrix / new-smileys

The New WordPress.com Smileys
27 stars 4 forks source link

Suggesting some other fallbacks #3

Closed Ipstenu closed 10 years ago

Ipstenu commented 10 years ago

The way WP is coded, those won't ever show up anyway.

Also spaces, not tabs ;)

ellatrix commented 10 years ago

Wait, what changed in this patch apart from whitespace? Why change everything to spaces?

ellatrix commented 10 years ago

We should also be cautious about introducing new variants. I don't want people to start using a variant that then won't be available in core/Jetpack/... :/

Ipstenu commented 10 years ago

Whitespace plus adding these:

:martini: :whiterussian: :heart:

Janneke Van Dorpe wrote:

We should also be cautious about introducing new variants. I don't want people to start using a variant that then won't be available in core/Jetpack/... :/

— Reply to this email directly or view it on GitHub https://github.com/avryl/new-smileys/pull/3#issuecomment-38703450.

ellatrix commented 10 years ago

Okay, could you add those without changing the tabs to spaces? I know some people prefer spaces, but that's just the WordPress coding standard: http://make.wordpress.org/core/handbook/coding-standards/php/#indentation

Ipstenu commented 10 years ago

eyes that doc I swear they change that back and forth.

No problem. Is it easier to close this and redo or ... just edit?