ellatrix / wp-front-end-editor

Front-end Editor for WordPress
https://wordpress.org/plugins/wp-front-end-editor/
340 stars 87 forks source link

Persistent "Save" button #143

Closed davidsdesk closed 8 years ago

davidsdesk commented 10 years ago

I'm running WP Front End Editor 0.10 on WP 3.9.2. Selecting "Edit Page" brings up the front-end editor, but after making changes and selecting "Update" the WP Front End Editor toolbar remains and the Update button does not go away. If I select "Cancel" my changes are visible.

ellatrix commented 10 years ago

We're going to update the Front-end editor soon after WP 4.0 is released. We can't do anything about 0.10 anymore... But isn't that supposed to happen? What do you expect to happen? You can just continue editing after updating, or leave the page. Would it be better to go to the post after?

davidsdesk commented 10 years ago

The only available option after selecting "Update" is "Cancel". It might be better to have "Cancel" before clicking "Update" and "Done" after clicking update. Or simply "Done" for both. When someone is in the editing mode selecting "Cancel" suggests that there changes are going to be disregarded.

ellatrix commented 10 years ago

Okay, now I get it. :) This will be different in 1.0, which we'll probably release next week, depending on when WP 4.0 comes out. Could you review this ticket after that?

davidsdesk commented 10 years ago

I just updated to WP 4.0 and am installing you latest release.

ellatrix commented 10 years ago

4.0 beta? That's great!

ellatrix commented 10 years ago

Just remember there's still a bit of work left. :)