ellatrix / wp-front-end-editor

Front-end Editor for WordPress
https://wordpress.org/plugins/wp-front-end-editor/
340 stars 87 forks source link

Feedback about what's editable and what's not #221

Closed marcelomazza closed 6 years ago

marcelomazza commented 9 years ago

When I click "Edit Post", I get confused about which stuff is editable and which is not. Maybe we can differentiate the editable content somehow. Possible idea, decreasing opacity to everything but the editable content:

wp-front-end-editor_overlay

ellatrix commented 9 years ago

We talked about this a lot before, but we could never make it the way we wanted it to work. Keep in mind different colour schemes, drop downs...

marcelomazza commented 9 years ago

What if, when you enter Edit mode:

I put together a small test here: http://codepen.io/marcelomazza/pen/KwexqK

@iseulde what do you think?

ellatrix commented 9 years ago

Now try this with twenty fourteen. :)

On Sat, Feb 28, 2015 at 9:22 PM Marcelo Mazza notifications@github.com wrote:

What if, when you enter Edit mode:

  • We set less opacity for all the elements
  • We set opacity 1 for .fee-post, its contents and all its parents

I put together a small test here: http://codepen.io/marcelomazza/pen/KwexqK

@iseulde https://github.com/iseulde what do you think?

— Reply to this email directly or view it on GitHub https://github.com/iseulde/wp-front-end-editor/issues/221#issuecomment-76546748 .

marcelomazza commented 9 years ago

front-end-editor-opacity

@iseulde ^

marcelomazza commented 9 years ago

The effect is even better in crowded templates:

front-end-editor-opacity1

ellatrix commented 9 years ago

Can you make a patch? I'd have to see this. If you're targeting specific areas based on the theme, that wouldn't work. If you're using the same logic for every theme, and doesn't look weird in any, okay. :) I just don't like the opacity to be 0. You don't have to add my username btw, I get notifications for everything.

marcelomazza commented 9 years ago

Done! #223. (did a pull request, not sure how to make a patch on GitHub)

The thing with the opacity is that, because we are applying it to nested elements, is not easy to set the correct level. In certain themes it looks great but in other not so... feel free to tweak it and play with it a bit.

jasonwhat commented 9 years ago

This seems like an important feature. I'd say one downside of the plugin so far is lack of feedback in the UX, there is very little to tell me I'm in edit mode, or that a post has been saved or published. In fact, I usually open a new tab to check it has been published for fear of losing work.

+1 for this feature and for some progress bar type mechanism to tell a user when a post has been saved or published.

ellatrix commented 8 years ago

I've added a dotted outline around editable areas. This is more like a distraction free mode. If your theme is already clean and a good reading experience, then it should be a good writing experience too. If you don't like writing in your own theme... then maybe it's not such a good reading experience for your readers! :) I'd prefer to keep it like this, but I'll leave it open for consideration. Maybe fading things out isn't that bad, but then again it's not easy to do. The theme could also use the classes and fade things out appropriately if it wanted too.

marcelomazza commented 8 years ago

That's great! A feedback is better than no feedback at all ;)

I'm glad you are still working on this 👍