Prevent from loading on BuddyPress pages (updated)

ellatrix / wp-front-end-editor

Front-end Editor for WordPress

https://wordpress.org/plugins/wp-front-end-editor/

340 stars 87 forks source link

Prevent from loading on BuddyPress pages (updated) #227

Closed christianwach closed 8 years ago

christianwach commented 9 years ago

A simple fix to prevent WP FEE from loading on BuddyPress pages. It solves (at least) a couple of issues:

WordPress Front-end Editor filters the_title, which causes warnings to be shown on Site Tracking page.
BuddyPress suppresses the "Edit Page" menu item on BP pages, but WP FEE reinstates it

Replaces #207

solhuebner commented 9 years ago

:+1:

ellatrix commented 8 years ago

I don't like adding BuddyPress specific things. The solution needs to be more general.

christianwach commented 8 years ago

@iseulde In what sense more general? A specific filter perhaps?

Third party code can fix this issue via code such as this but since WP FEE already accommodates the 'page_for_posts' exception, it would seem trivial to support BuddyPress pages as well. Otherwise, I suspect we'll end up in a ping-pong between WP FEE and BuddyPress as to who supports whom!

ellatrix commented 8 years ago

Yeah it would need to be a filter. Or those pages should be CPTs, but I'm not familiar with BP.

christianwach commented 8 years ago

No worries, https://github.com/cuny-academic-commons/social-paper/commit/a0180a699928e7b65128b30d57da566d6b97439f seems like the way forward. The "documentation" label seems appropriate.

ellatrix commented 8 years ago

Let's leave it open then for docs. :)

ellatrix commented 8 years ago

Done in 91be1b62cc30ef9025b5bfc997f311be6833e09c.