WordPress 4.3 issues

[r-a-y]

Issues:

• Console errors when clicking on the "Edit Page" button to turn FEE on - commit 0569644
• Floating toolbar doesn't show up - commit cc94a5c (hack fix; this should be fixed properly!)
• Clicking on the 'remove' button multiple times in the image floating toolbar removes parent elements - see issue no.266

My compiled fixes for current release version: https://github.com/iseulde/wp-front-end-editor/pull/261/files

My compiled fixes for development version on GitHub: https://github.com/iseulde/wp-front-end-editor/pull/268/files

[phpbits]

Hi,

I did some testing too and I'm encountering this issue. Tried to contact the author via slack but I'm not getting any response yet. Thanks!

[phpbits]

Hi,

Did you find any solution? Thanks!

Cheers, phpbits

[NicktheGeek]

Note for anyone attempting this work around. The callback and function in the example do not match. The code should be updated to

/**
 * Removes the 'wplink' TinyMCE plugin from FEE.
 */
function my_fee_tinymce_remove_wplink( $retval ) {
    $key = array_search( 'wplink', $retval );
    if ( false !== $key ) {
        unset( $retval[$key] );
    }

    return $retval;
}
add_filter( 'fee_tinymce_plugins', 'my_fee_tinymce_remove_wplink' );

For sanity's sake you may want to edit the callback and function name to use a prefix other than "my_" just in case a plugin or theme happens to be using that same prefix.

This update caused it to mostly work for me. I'm working on identifying some CSS issues. May be due to the custom setup I have.

[laurgaut]

Hello, wa can see that 4.3.1 version of wordpress corrects the wplink tinymce plugin

https://codex.wordpress.org/Version_4.3.1 TinyMCE: Plugin wplink throw js TypeError: editor.wp undefined #33393

I think, after installation of this update, FEE will work

[NicktheGeek]

I can confirm that after 4.3.1 was updated and the max version was increased in package.json I was able to remove the code that stopped the wplink from loading and everything worked.

[r-a-y]

I've encountered one issue in WP 4.3.x.

After adding a media item with FEE, the toolbar does not show up when you mouseover the item. In WP 4.2, this toolbar showed up:

Will report back if I find a fix.

Update: I've put up a temporary fix in my 4.3 branch: https://github.com/iseulde/wp-front-end-editor/pull/261/files

This is considered a hack as I'm not too familiar with the FEE codebase to fix this properly.

[picajoso]

Hi, I've just tried updating to WP-4.3.1 but the plugin is still not working there. I'm conflicted because I'd like to continue using this fantastic plugin, but my blog security is at risk if I don't update to the latest WP...

I wonder if there's a public update to the plugin that normal users like me (I'm a bit lost when you talk about those kind of patches) can use in the near future. Is there an easy way to make this work with WP 4.3.1?

Regards!

[picajoso]

I've updated my blog to WP-4.3.1 and as r-a-y says, the toolbar isn't present anymore, you've got to hover just over the selection to see the little indication that allows you to insert a link, put in bold or italics, etc. I've edited the two files r-a-y mentions on the plugin's code, but no luck whatsoever.

Is there a new version fixing this coming soon?

[r-a-y]

I've edited the two files r-a-y mentions on the plugin's code, but no luck whatsoever.

You have to clear your browser cache to see the changes.

[picajoso]

I'm affraid that doesn't make any difference. I've tried to use different browsers and even a incognito session on them, and it still doesn't show the toolbar :(

[r-a-y]

I think I see the problem. I have SCRIPT_DEBUG set to true: https://codex.wordpress.org/Debugging_in_WordPress#SCRIPT_DEBUG

So I'm loading the unminified JS files during testing. I need to patch the minified JS file as well for production use. I'll try to get to this soon, but in the meantime, you could set SCRIPT_DEBUG to true and it should work.

[picajoso]

Thanks for the tip, but it isn't working :( As far as I know setting that to true is the only thing I have to do. I don't need to restart my webserver, for example. So I've made the change, but nothing happens. Still no toolbar.

[r-a-y]

Check your JS and see if the changes you made are actually implemented.

Try purging your cache in both the browser and WP cache (if you're using a caching plugin).

[r-a-y]

Since iseulde's latest commits to bump compatibility for WP 4.3, I'm still encountering issues.

Here are my latest fixes: https://github.com/iseulde/wp-front-end-editor/pull/268/files

[ellatrix]

I know not everything is fixed. There are quite a lot of remaining issues. Sorry for the inconvenience!

[picajoso]

WordPress 4.4 has come and there are new problems. I wonder if you can take a look iseulde. r-a-y, maybe you can see if you can do something too?

[ellatrix]

Anything left here, please make a list. :) Thanks!

[picajoso]

It's working really great, thank you @iseulde !

[ellatrix]

Thanks! New issues for new problems please.