search

ellatrix / wp-front-end-editor

Front-end Editor for WordPress
https://wordpress.org/plugins/wp-front-end-editor/
340 stars 87 forks source link

WordPress 4.3 compatibility #261

Closed r-a-y closed 8 years ago

r-a-y commented 9 years ago

See #257.

iseulde - The only issue that I've found with WP 4.3 and FEE is since the 'wplink' TinyMCE plugin received updates in WP 4.3, this broke how FEE saves frontend edits.

Do you plan on fixing support for 'wplink'? If not, perhaps we can remove the 'wplink' plugin from FEE's TinyMCE plugin list. I didn't add a commit to remove the plugin since I'm unsure if you wanted to support it or not.

Update: The floating toolbar does not show up in WP 4.3. I've added a temporary fix for this in commit 4b74242. Feel free to ignore that commit if/when you fix this properly.

RavanH commented 8 years ago

Just tested with 4.4-alpha-34650 and it seems to be working there too... No extensive tests, only basic page/post editing and saving but found no issues yet.

To allow easy testing on current nightlies, I suggest upping max version to 4.4-beta

ellatrix commented 8 years ago

Version bumped and toolbar fixed.

r-a-y commented 8 years ago

Version bumped and toolbar fixed.

I'm still experiencing issues with the floating toolbar; it doesn't show up. I've added a hack fix here: https://github.com/r-a-y/wp-front-end-editor/commit/cc94a5ca944c90f6312edffd7b32193db6b338e2

Tested on FEE master branch, WordPress 4.3.1 and the twentytwelve theme.

Update: I've added a new pull request here: https://github.com/iseulde/wp-front-end-editor/pull/268/files