search

elle-Bee / Road-Lane-Detection-System

https://t.me/+__4-ipvNiw0yNTY1
MIT License
0 stars 4 forks source link

add: black and pylint to github workflow #8

Closed kausthub-kannan closed 11 months ago

kausthub-kannan commented 11 months ago

Issue ticket Number:

5

Changes done:

  1. Added github/workflow
  2. Configured black and pylint (black to run first and followed by pylint)
  3. Added init.py
  4. Added requirements.txt
  5. Added .gitignore
kausthub-kannan commented 11 months ago

@elle-Bee Can try running the workflow manually? I have added black and pre-commit along with which I have added other pre-commit hooks for standard code format. The workflow is not being triggered for some reason even in my fork hence added workflow dispatch to trigger it manually

Thank You

elle-Bee commented 11 months ago

Hey @kausthub-kannan I'm seeing that you are working on a branch named kausthub-kannan:pylint-workflow. Have you tried pushing the changes into the main branch of your own fork? Maybe that's the reason why it is not triggering.

kausthub-kannan commented 11 months ago

@elle-Bee Thanks for the help, after pushing it to the main the workflow works. Shall I close this PR and create a new one via main branch from my fork?

Screenshot-20231212-231954

elle-Bee commented 11 months ago

Yes, make try making the PR from the main branch of your fork