search

elleFlorio / svn-docker

Lightweight Docker image to build a container running an SVN server
MIT License
145 stars 106 forks source link

Update docker run command to preserve configurations #32

Closed layanto closed 3 years ago

layanto commented 3 years ago

Fixes https://github.com/elleFlorio/svn-docker/issues/30

layanto commented 3 years ago

I removed the You can optionally bind a local folder to the container folder that will store your repositories note in README because I don't think repositories volume is optional. Imagine losing all subversion repo commits due to restarting container!

layanto commented 3 years ago

Should also update the Dockerfile to include VOLUME /home/svn /etc/subversion /opt/svnadmin/data. But seems to still work without it. I think adding this to Dockerfile means that even if user runs docker run -d --name svn-server -p 80:80 -p 3690:3690 elleflorio/svn-server without any of the -v flags, docker will automatically create temporary volumes for them.

elleFlorio commented 3 years ago

yeah, you are right. I would keep it with the -v flags for now.

Thank you for the contribution! 😄