search

elleFlorio / svn-docker

Lightweight Docker image to build a container running an SVN server
MIT License
145 stars 106 forks source link

Simplify for start #42

Closed sea-kg closed 7 months ago

sea-kg commented 1 year ago
georgeslabreche commented 1 year ago

@sea-kg: This is a great! Here are some issues that I encountered that may be problematic.

1) Exposed default credentials could be problematic

image

2) Why include the source of svnadmin instead of just cloning or wget a tagged version from a public repo?

sea-kg commented 1 year ago

@georgeslabreche, thanks!

  1. It's just default admin/admin for easy start (after start user must change login/password) In another solution - can be patched the svnadmin for first start (just asking password for admin user) like a gitlab doing

  2. Included sources because in current time this has one patch, and in future can be more patches (for example to fix problem with #41) second point no need for downloading every time from github for build image, also 3rdparty repository can be moved to another repository or just removed - don't worry we can build docker image in any time

elleFlorio commented 7 months ago

I am sorry but I could not give this repo the love it deserves. 😞 So I decided to archive it and make it read only, so people can fork and apply their changes.

Thank you anyway for your PR, I appreciate the contribution you submitted! ❤️