ellenhp / bambu-farm

Self-hostable Bambu Cloud alternative
GNU Affero General Public License v3.0
129 stars 9 forks source link

Come up with a good way to track upstream plugin versions #6

Open ellenhp opened 10 months ago

ellenhp commented 10 months ago

Latest Bambu Studio will refuse to operate with this plugin because I haven't updated the version tag yet, which is such a bummer because I don't think the API has changed substantially. I see two options: Build a bunch of version tags in CI, or somehow pull out the expected version tag at runtime from the binary that dlopens the plugin. The version tag shows up in strings and has a pretty consistent format so we could just grep for it?

Alternatively, I could go to upstream and ask them to stop breaking things. If Prusa Slicer were LGPL or something I'd maybe understand this kind of behavior but it's not, it's AGPL, and if they're going to violate the AGPL by shipping a slicer that only functions with a closed-source plugin, the least they can do is stop breaking the interface.

Kyon147 commented 10 months ago

grep'ing the string makes the most sense I think from an automated standpoint. Saves the mess of having to build a bunch of version tags each time and try and keep them in sync with what Bamboo expects for the slicer to work.