search

elleracompany / craft-cookie-consent

GDPR-Compliant cookie consent banner for Craft CMS
Other
6 stars 5 forks source link

Tailwind Based Redesign (enhancement?) #29

Open kerns opened 4 years ago

kerns commented 4 years ago

Just offering to work with you on a new design implementation in tailwind that completely rethinks the way we interface with the javascript layer, ...with an eye toward making future upgrades (or other layouts) much, much easier to roll-out. So a more concrete/disciplined abstraction of function and layout, ...if it's possible.

This is still a little rough but it's from my very much working implementation. It's a bottom bar modal that also employs a full screen overlay to prevent interaction with the site until some form of consent – this could be an option.

Screen Shot 2020-05-29 at 15 30 25

The tab is a small button at the bottom...

Screen Shot 2020-05-29 at 15 36 36

That opens this full screen with details and options for each group...

Screen Shot 2020-05-29 at 15 38 06

Maybe we can work on something more in this direction in the future. I know a lot of developers would be delighted to see something tailwind based.

sieir commented 4 years ago

This is definitely interesting and something we have thought about doing for a while. Would your implementation of this be something you would like to share with us?

kerns commented 4 years ago

Absolutely. Only, I would write this differently I think in a greenfield scenario. I was really just adapting to the code model already in place ...and I took some shortcuts. 😬 But, well ...just let me know how I can help.

sieir commented 4 years ago

My apologies for the slow response time. Totally understandable with the shortcuts, it would just be interesting and helpful to see your implementation to get an external perspective :) Do you have a fork of this or another preferred way for us to have a look?

kerns commented 4 years ago

No worries. I will think about the easiest way to hand-off in light of my schedule at the moment. I am also using some Sass/.scss for the generation of lightswitches... it could be nice that you include these in your dist as well. I will look at it as soon as I can!

MichaelBrauner commented 3 years ago

Yes. That would be very nice. Looking forward to it!

kerns commented 3 years ago

Yes. That would be very nice. Looking forward to it!

Let's setup a playground some place using TW 2.0. I can rebuild the same or similar design, one that is also dark mode compatible.

sieir commented 3 years ago

Yes. That would be very nice. Looking forward to it!

Let's setup a playground some place using TW 2.0. I can rebuild the same or similar design, one that is also dark mode compatible.

Would perhaps a repository fork with a pull request suffice? https://gist.github.com/Chaser324/ce0505fbed06b947d962

kevinmu17 commented 3 years ago

This is a great idea to make available within the resource folder of the plugin (where script.js & style.css rest) A developer can than choose to use a tailwind build or not at the site settings > template

I would not recommend to make tailwind a default because you lose agility when hooking into just 1 framework