search

elleracompany / craft-cookie-consent

GDPR-Compliant cookie consent banner for Craft CMS
Other
6 stars 5 forks source link

Update banner.twig #69

Closed mikewink closed 2 years ago

mikewink commented 3 years ago

Add missing t('cookie-consent') throughout the banner

jellingsen commented 3 years ago

Seems like you've added a non-english translation in src/translations/en/cookie-consent.php

mikewink commented 2 years ago

Seems like you've added a non-english translation in src/translations/en/cookie-consent.php

My fault, you are right. That was not supposed to be in PR and I completely forgot to fix that. The change to the banner template did not make into 4. I thought it would make it easier to have a dedicated file for cookie consent translations rather than mixing them with the general language files, as this can result in race conditions if you use the same words in a different spot as well.

jellingsen commented 2 years ago

I agree, this should be scoped to the cookie-consent translation files.

I think i need to go through the entire plugin an update other translations as well. I'll make a more general issue and get it fixed.