search

elleracompany / craft-cookie-consent

GDPR-Compliant cookie consent banner for Craft CMS
Other
6 stars 5 forks source link

[Craft 4] Unable to add/reorder/delete table rows #90

Closed WHITE-developer closed 1 year ago

WHITE-developer commented 2 years ago

Since Craft 4 the defaults for editable tables changed. https://github.com/craftcms/cms/commit/1b197ef7c6425f59544b9097f8339beeea9de771 allowAdd, allowReorder and allowDelete are now default false, so should be added here https://github.com/elleracompany/craft-cookie-consent/blob/master/src/templates/settings/_includes/group.twig#L100

peerfischer commented 1 year ago

Will there be an update?

mikewink commented 1 year ago

@WHITE-developer thank you very much for the debugging. I created a PR https://github.com/elleracompany/craft-cookie-consent/pull/93 for your fix.

Lets hope it will be reviewed soon. Your solution works well for me.

jellingsen commented 1 year ago

Thank you so much for the debugging @WHITE-developer and for the PR @mikewink !

And I applogize for the slow response to this.

I've released v4.0.4 with this fix.

WHITE-developer commented 1 year ago

@jellingsen Thanks for the fix, but looks like the updates isn't pushed to packagist? Could you update it their also?

jellingsen commented 1 year ago

@WHITE-developer my applogies! Should be updated now.