search

elli-lib / elli

Simple, robust and performant Erlang web server
https://github.com/elli-lib/elli/blob/develop/doc/README.md
MIT License
324 stars 38 forks source link

fix request scheme, host and port in req record #110

Open tsloughter opened 2 years ago

tsloughter commented 2 years ago

Tests were failing on 21 because of the lack of uri_string, so I've ditched support of OTP-21. Fixes https://github.com/elli-lib/elli/issues/103

yurrriq commented 2 years ago

I see dialyzer is mad too. I can probably take a look tonight.

tsloughter commented 2 years ago

parse_path isn't meant to be a public api, but only for exported for tests, so I don't think this warrants a major version bump.

That said, you already started on a major version bump, right? I figured it would go with that anyway.

yurrriq commented 2 years ago

parse_path isn't meant to be a public api, but only for exported for tests, so I don't think this warrants a major version bump.

I'm convinced.

That said, you already started on a major version bump, right? I figured it would go with that anyway.

We have this outdated one at least: https://github.com/elli-lib/elli/pull/102