elli-lib / elli

Simple, robust and performant Erlang web server
https://github.com/elli-lib/elli/blob/develop/doc/README.md
MIT License
314 stars 37 forks source link

Fix spec for elli:stop/1 #113

Closed paulo-ferraz-oliveira closed 5 days ago

paulo-ferraz-oliveira commented 11 months ago

Closes #111.

Depends on the CI file updates from #114, so shall be rebased and updated (if required) after that one.

codecov-commenter commented 11 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.40%. Comparing base (05e24b1) to head (bda6af9). Report is 26 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #113 +/- ## ========================================== + Coverage 76.30% 76.40% +0.09% ========================================== Files 12 12 Lines 764 750 -14 ========================================== - Hits 583 573 -10 + Misses 181 177 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

paulo-ferraz-oliveira commented 11 months ago

~CI failing for OTP 26, and 25. I'll try to replicate locally.~

paulo-ferraz-oliveira commented 11 months ago

~It's possible the failure for non-OTP 26 is due to #99, since re-executing the tests (in a fork) showed ✅.~

paulo-ferraz-oliveira commented 11 months ago

~Removed OTP 26 from scope, since there're SSL -related issues to solve. Should be moved to a new PR, I guess...~

paulo-ferraz-oliveira commented 8 months ago

Moved to draft. These don't need to be reviewed before #114, after which I'll rebase.

paulo-ferraz-oliveira commented 6 days ago

@tsloughter