Closed paulo-ferraz-oliveira closed 3 weeks ago
Patch coverage: 82.35%
and project coverage change: +0.07%
:tada:
Comparison is base (
3ec3522
) 76.32% compared to head (829beda
) 76.40%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
~CI failing for OTP 26, 24, and 22. I'll try to replicate locally.~
~It's possible the failure for non-OTP 26 is due to #99, since re-executing the tests (in a fork) showed ✅.~
~Removed OTP 26 from scope, since there're SSL -related issues to solve. Should be moved to a new PR, I guess...~
Woo, these are all looking good.
And yea, for 26 the ssl certs may need to be re-created. I had to do this for chatterbox tests too.
Is anything lacking for this one to get merged? I can then rebase and update the other ones.
I think I'll deal with OTP 26 in a separate PR so as to not inflict further confusion in these pull requests... 😄
@tsloughter, if you prefer I can also reduce the scope for this and do multiple pull requests to an isolated branch until you're fully satisfied and then we merge to the main branch.
This doesn't look too bad, I just hadn't taken a close look.
@tsloughter, what's required to push this forward?
Hey sorry, it is just a large PR. But it looks like a lot of it is formatting?
👋 it's probably the commit related to Elvis, but I can try to break it down further.
I'm moving to draft, to be able to break it down into several pull requests. Once that's done, I'll close this one without it being merged.
All new pull requests mentioned in the top description.
Closes #103.
This pull request is being split into several other pull requests, to ease review. These are listed below.