Closed paulo-ferraz-oliveira closed 3 weeks ago
Attention: Patch coverage is 77.77778%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 76.40%. Comparing base (
3ec3522
) to head (9db9cc1
).
Files | Patch % | Lines |
---|---|---|
src/elli_http.erl | 77.77% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@tsloughter
Thanks for these! I will get to this very soon.
This is mostly removing code and updating the CI pipeline for 22-25 (now with cache).
(I took the liberty to update the minimum to OTP 22 - this was previously, in the "other" pull request OTP 21, but in the meantime an extra OTP version was released)
In CI we also update some of the action tools' versions.
Further considerations
The pull request is probably best seen with
Hide whitespace
enabled, since there's some changes that are just indentation ones.I'm also temporarily disabling
rebar3_lint
in this pull request, since that bring other issues with it requiring to be updated, but will handle it in a subsequent pull request.Note: support for OTP 26 and 27 is not present, as this was discussed before: https://github.com/elli-lib/elli/pull/114#issuecomment-1654784150