elli-lib / elli

Simple, robust and performant Erlang web server
https://github.com/elli-lib/elli/blob/develop/doc/README.md
MIT License
314 stars 37 forks source link

Update code for the new OTP 22-25 maintenance range #119

Closed paulo-ferraz-oliveira closed 3 weeks ago

paulo-ferraz-oliveira commented 3 weeks ago

This is mostly removing code and updating the CI pipeline for 22-25 (now with cache).

(I took the liberty to update the minimum to OTP 22 - this was previously, in the "other" pull request OTP 21, but in the meantime an extra OTP version was released)

In CI we also update some of the action tools' versions.

Further considerations

The pull request is probably best seen with Hide whitespace enabled, since there's some changes that are just indentation ones.

I'm also temporarily disabling rebar3_lint in this pull request, since that bring other issues with it requiring to be updated, but will handle it in a subsequent pull request.

Note: support for OTP 26 and 27 is not present, as this was discussed before: https://github.com/elli-lib/elli/pull/114#issuecomment-1654784150

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.40%. Comparing base (3ec3522) to head (9db9cc1).

Files Patch % Lines
src/elli_http.erl 77.77% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #119 +/- ## ========================================== + Coverage 76.32% 76.40% +0.07% ========================================== Files 12 12 Lines 756 750 -6 ========================================== - Hits 577 573 -4 + Misses 179 177 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

paulo-ferraz-oliveira commented 3 weeks ago

@tsloughter

tsloughter commented 3 weeks ago

Thanks for these! I will get to this very soon.