elli-lib / elli

Simple, robust and performant Erlang web server
https://github.com/elli-lib/elli/blob/develop/doc/README.md
MIT License
314 stars 36 forks source link

Tweak `rebar.config` (update deps then fixed issue warnings) #120

Closed paulo-ferraz-oliveira closed 6 days ago

paulo-ferraz-oliveira commented 3 weeks ago

We update versions of deps and plugins and fix warnings issued from that. It's possible a commit-by-commit review makes it easier to spot how we did stuff.

Further considerations

Most of the changes done previously in https://github.com/elli-lib/elli/pull/114 where from elvis_core's rule operator_spaces, which is disabled in this pull request.

⚠️ as per https://github.com/elli-lib/elli/pull/120#discussion_r1638068811 we also up min. supported OTP version to 24.

paulo-ferraz-oliveira commented 3 weeks ago

CI's failing: I'm up'ing rebar3 version, since it's possible it suffered a fix that CI didn't get to (using 3.14, at this moment)

codecov-commenter commented 3 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.40%. Comparing base (05e24b1) to head (4e9012f). Report is 9 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #120 +/- ## ========================================== + Coverage 76.30% 76.40% +0.09% ========================================== Files 12 12 Lines 764 750 -14 ========================================== - Hits 583 573 -10 + Misses 181 177 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

paulo-ferraz-oliveira commented 3 weeks ago

Merge conflicts are solved.

paulo-ferraz-oliveira commented 1 week ago

@tsloughter

tsloughter commented 6 days ago

Will merge with that one fix.

tsloughter commented 6 days ago

I figure it its a general function in the tests for use anywhere so may as well cover them all.

paulo-ferraz-oliveira commented 6 days ago

Thanks. I'll move to the next one, by rebasing on top of the main branch.