Closed paulo-ferraz-oliveira closed 6 days ago
CI's failing: I'm up'ing rebar3
version, since it's possible it suffered a fix that CI didn't get to (using 3.14
, at this moment)
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.40%. Comparing base (
05e24b1
) to head (4e9012f
). Report is 9 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Merge conflicts are solved.
@tsloughter
Will merge with that one fix.
I figure it its a general function in the tests for use anywhere so may as well cover them all.
Thanks. I'll move to the next one, by rebasing on top of the main branch.
We update versions of deps and plugins and fix warnings issued from that. It's possible a commit-by-commit review makes it easier to spot how we did stuff.
Further considerations
Most of the changes done previously in https://github.com/elli-lib/elli/pull/114 where from
elvis_core
's ruleoperator_spaces
, which is disabled in this pull request.⚠️ as per https://github.com/elli-lib/elli/pull/120#discussion_r1638068811 we also up min. supported OTP version to 24.