search

elli-lib / elli

Simple, robust and performant Erlang web server
https://github.com/elli-lib/elli/blob/develop/doc/README.md
MIT License
322 stars 38 forks source link

Instrumentation infrastructure for plugins #27

Open deadtrickster opened 7 years ago

deadtrickster commented 7 years ago

Add API so plugins can instrument themselves, just like main Elli does. Something generic, or just use Prometheus/Prometheus data model?

yurrriq commented 6 years ago

:+1: for generic, but skewing Prometheus-friendly.

yurrriq commented 6 years ago

Any new thoughts on this?

tsloughter commented 6 years ago

I don't understand what this means.

yurrriq commented 6 years ago

I think the idea is to codify and expose an API for calculating timings, as we do internally, such that a middleware can do the same to instrument itself, without having to reimplement anything... if that makes sense.

tsloughter commented 6 years ago

Ah ok, that is how I took it at first too but not sure how that relates to prometheus? We are just talking about the timing and size atoms, like those that already exist?

yurrriq commented 6 years ago

/ping @deadtrickster

paulo-ferraz-oliveira commented 1 year ago

Should we consider Open Telemetry for this? I wouldn't mind working on it, but:

  1. I need to know what timings we're interested in (all of them?)
  2. if I could come up with the scope and name for the telemetry events or if there's ideas around those already...