do not use x-forwarded-for for peer - Githubissues

elli-lib / elli

Simple, robust and performant Erlang web server

https://github.com/elli-lib/elli/blob/develop/doc/README.md

MIT License

324 stars 38 forks source link

do not use x-forwarded-for for peer #75

Closed tsloughter closed 5 years ago

tsloughter commented 5 years ago

This was brought to our attention in this issue https://github.com/elli-lib/elli/issues/68

I finally went and dug through the git logs to try finding why Elli ever used x-forwarded-for for the peer and there does not appear to be an explanation. So I think simply removing it is the best course of action.

coveralls commented 5 years ago

Coverage increased (+0.07%) to 76.027% when pulling 27b2132280ab1fab94a3e739d93be4dc502e97e8 on tsloughter:peername into 966e89a314d32d5ed2ba6fa640d48115eef0b858 on elli-lib:develop.

coveralls commented 5 years ago

Coverage increased (+0.07%) to 76.027% when pulling 27b2132280ab1fab94a3e739d93be4dc502e97e8 on tsloughter:peername into 966e89a314d32d5ed2ba6fa640d48115eef0b858 on elli-lib:develop.

coveralls commented 5 years ago

Coverage increased (+0.07%) to 76.027% when pulling 27b2132280ab1fab94a3e739d93be4dc502e97e8 on tsloughter:peername into 966e89a314d32d5ed2ba6fa640d48115eef0b858 on elli-lib:develop.

coveralls commented 5 years ago

Coverage increased (+0.07%) to 76.027% when pulling 27b2132280ab1fab94a3e739d93be4dc502e97e8 on tsloughter:peername into 966e89a314d32d5ed2ba6fa640d48115eef0b858 on elli-lib:develop.

coveralls commented 5 years ago

Coverage increased (+0.07%) to 76.027% when pulling 27b2132280ab1fab94a3e739d93be4dc502e97e8 on tsloughter:peername into 966e89a314d32d5ed2ba6fa640d48115eef0b858 on elli-lib:develop.

coveralls commented 5 years ago

Coverage increased (+0.07%) to 76.027% when pulling 27b2132280ab1fab94a3e739d93be4dc502e97e8 on tsloughter:peername into 966e89a314d32d5ed2ba6fa640d48115eef0b858 on elli-lib:develop.

coveralls commented 5 years ago

Coverage increased (+0.07%) to 76.027% when pulling 27b2132280ab1fab94a3e739d93be4dc502e97e8 on tsloughter:peername into 966e89a314d32d5ed2ba6fa640d48115eef0b858 on elli-lib:develop.

coveralls commented 5 years ago

Coverage increased (+0.07%) to 76.027% when pulling 27b2132280ab1fab94a3e739d93be4dc502e97e8 on tsloughter:peername into 966e89a314d32d5ed2ba6fa640d48115eef0b858 on elli-lib:develop.

coveralls commented 5 years ago

Coverage increased (+0.07%) to 76.027% when pulling 27b2132280ab1fab94a3e739d93be4dc502e97e8 on tsloughter:peername into 966e89a314d32d5ed2ba6fa640d48115eef0b858 on elli-lib:develop.