elli-lib / elli

Simple, robust and performant Erlang web server
https://github.com/elli-lib/elli/blob/develop/doc/README.md
MIT License
324 stars 38 forks source link

Fix unexpected crash during SSL tests #91

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

Crash (didn't affect tests, but gave off the impression something was wrong) was:

=ERROR REPORT==== 29-Oct-2020::11:08:45 ===
Elli request (pid #Port<0.86655>) unexpectedly crashed:
shutdown

=ERROR REPORT==== 29-Oct-2020::11:08:45 ===
Elli request (pid <0.396.0>) unexpectedly crashed:
{shutdown,{gen_statem,call,[<0.437.0>,{recv,0,60000},infinity]}}
paulo-ferraz-oliveira commented 3 years ago

In OTP 20.3, at least, it did make 1 test fail, though.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.3%) to 75.546% when pulling 4b633252436da3aaa146849ac96c2376c79c4de7 on paulo-ferraz-oliveira:fix/unexpected_test_crash into 968afee385f46c053fd46858713261db7dc03af4 on elli-lib:main.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.3%) to 75.546% when pulling 4b633252436da3aaa146849ac96c2376c79c4de7 on paulo-ferraz-oliveira:fix/unexpected_test_crash into 968afee385f46c053fd46858713261db7dc03af4 on elli-lib:main.

paulo-ferraz-oliveira commented 3 years ago

Now that I see the tests failing in Travis CI, executing them locally shows that "sometimes" they fail on OTP 23. Might it be a timing issue?

paulo-ferraz-oliveira commented 3 years ago

@tsloughter: is this OK for merge?

tsloughter commented 3 years ago

Ah yea. One sec, let me just rerun travis once more.

tsloughter commented 3 years ago

Maybe I'll finally move this to github actions soon...

yurrriq commented 3 years ago

relates to #90