search

elli-lib / elli

Simple, robust and performant Erlang web server
https://github.com/elli-lib/elli/blob/develop/doc/README.md
MIT License
314 stars 37 forks source link

Flaky SSL test returning `{badmatch, []}` periodically #99

Open jeffgrunewald opened 3 years ago

jeffgrunewald commented 3 years ago

Currently there appears to be a timing issue in executing the elli_ssl_tests. This was observed during trivial changes refactoring function internals without changing their end result and exposing private functions as public. It was also observed on different OTP versions within the matrix execution running in GitHub actions (the first time on OTP 22.3.4.2, the second time on OTP 21.3.8.16) and was not reproducible locally (running on 2017 Macbook Pro with i5, 8 gb RAM). At the time of the failures, GitHub actions is set to execute the build matrix on "ubuntu-latest" which at time of writing is still 18.04, version 20210111.1 in GH actions with a pending update to 20.04. (https://github.com/actions/virtual-environments/blob/ubuntu18/20210111.1/images/linux/Ubuntu1804-README.md)

Re-running the tests with subsequent builds successfully resolved the issue temporarily.

jeffgrunewald commented 3 years ago

The relevant Erlang setup step running in CI during these builds is bajankristof/setup-erlang@master

yurrriq commented 3 years ago

Thank you!