search

elli-lib / elli_fileserve

Development has moved to elli_static.
https://github.com/elli-lib/elli_static
0 stars 4 forks source link

Use mimerl #8

Closed yurrriq closed 7 years ago

yurrriq commented 7 years ago

Comments wanted!

Instead of using parse_trans's ct_expand on priv/mime.types, use mimerl.

N.B. These changes break (and remove) the following statement:

You can also drop in your own MIME/content types by editing priv/mime.types before compiling.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 37e2a6ea9537680b131cb26cb2dbc573734c5ed1 on feature/mimerl into 306d035d5e4e783d7f415d1f32f866320e9c9a8b on develop.

yurrriq commented 7 years ago

Note: Job #11.2 passed, which resolves #4.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e071b2756aab588be618fb25cf809019e81b7c97 on feature/mimerl into 817d2bc7890ddfe01239cc378860e80d32e8dc45 on develop.

eproxus commented 7 years ago

Looks like a good change and reduces complexity. Custom MIME types can be added later if someone actually need it?

yurrriq commented 7 years ago

Sounds good to me.