search

elli-lib / elli_prometheus

Elli middleware for collecting stats via Prometheus.
https://github.com/elli-lib/elli_prometheus/blob/master/doc/elli_prometheus.md
Other
14 stars 8 forks source link

Update to latest prometheus.erl #10

Closed yurrriq closed 7 years ago

yurrriq commented 8 years ago

Might need your help on this, @deadtrickster.

deadtrickster commented 8 years ago

Sure, can this wait for a couple of days?

yurrriq commented 8 years ago

Definitely :smile:

deadtrickster commented 7 years ago

Once https://github.com/elli-lib/elli/issues/7 resolved I'll update this.

Questions: https://github.com/elli-lib/elli_prometheus/blob/master/src/elli_prometheus.erl#L61 {0,0,0} defaults here. I don't like them, why are they needed? I glanced through elli code, can it really happen that those times wouldn't be set? Why user times and not request times? maybe we want both?

deadtrickster commented 7 years ago

Also time units, we can stay with microseconds but now when the is new timing system, we can use seconds to follow Prometheus best practices guide. What you think? You said you have grafana dashboard setup already.

yurrriq commented 7 years ago

The dashboard is very basic and I'd rather follow the Prometheus best practices guide than avoid tweaking the dashboard.

yurrriq commented 7 years ago

This is resolved, right? Feel free to close, @deadtrickster.