search

elli-lib / elli_prometheus

Elli middleware for collecting stats via Prometheus.
https://github.com/elli-lib/elli_prometheus/blob/master/doc/elli_prometheus.md
Other
14 stars 8 forks source link

Content negotiation #13

Closed deadtrickster closed 7 years ago

deadtrickster commented 7 years ago

Enable content negotiation and set config default format to auto. Set default Accept value to text/plain.

yurrriq commented 7 years ago

Thanks for this. Looks great.

yurrriq commented 7 years ago

Probably. I'm commenting on my phone. Looks like elli:header() allows string() Values too, so this is fine. Thanks again!

https://github.com/elli-lib/elli/blob/2.0.0/src/elli.erl#L40

yurrriq commented 7 years ago

Actually, can you rebase on develop so we can merge it there? I'd like to keep master for releases only.

yurrriq commented 7 years ago

Perhaps I should make develop the default branch and write a little CONTRIBUTING.md.

deadtrickster commented 7 years ago

Develop is outdated here, Probably sync it with master first?

yurrriq commented 7 years ago

Will do. Gonna be later though, heading out for a bit now I think.

deadtrickster commented 7 years ago

ping

yurrriq commented 7 years ago

Thanks for your patience :). I've synced develop with master now.

deadtrickster commented 7 years ago

changed based branch to elli-lib:develop. can we merge now?