search

elli-lib / elli_prometheus

Elli middleware for collecting stats via Prometheus.
https://github.com/elli-lib/elli_prometheus/blob/master/doc/elli_prometheus.md
Other
14 stars 8 forks source link

include accept app in applications list #18

Closed tsloughter closed 7 years ago

tsloughter commented 7 years ago

Without this the request will crash, returning a 500 status, unless the user puts accept in their projects .app file to ensure it is included and loaded in their release.

yurrriq commented 7 years ago

:+1: The build failure looks unrelated, so I think this is good to merge, @deadtrickster.

deadtrickster commented 7 years ago

Yeah, but accept isn't different from prometheus or elli is it? just another dependency. Why we not listing elli & prometheus (esp prometheus)?

tsloughter commented 7 years ago

Ah, true, prometheus should be one, but not elli. Since this is something that has to be included in an already existing elli app. I'm adding prometheus though.

deadtrickster commented 7 years ago

Thanks!