elli-lib / elli_prometheus

Elli middleware for collecting stats via Prometheus.
https://github.com/elli-lib/elli_prometheus/blob/master/doc/elli_prometheus.md
Other
14 stars 8 forks source link

Add status_class label and make status_code optional #4

Closed yurrriq closed 8 years ago

yurrriq commented 8 years ago

I would also like to note that status_code label can lead to 'overflow'. While set of values of this label is definitely finite it's still can be large. Prometheus treats each label set as separate time series. Likely there is also usability issue - imagine you want to graph all successful replies then you have to use regex matches. So maybe introduce status_class label and make status_code optional?

See #3 for discussion.