search

ellie-commons / byte

A Music Player designed for elementary OS
https://github.com/alainm23/byte
GNU General Public License v3.0
160 stars 16 forks source link

Add minimize button on HeaderBar #44

Closed redian23 closed 5 years ago

redian23 commented 5 years ago

I think minimize button need when need to save app in dashboard (plank) without close. Close button remove app with plank.

Screenshot from 2019-09-19 15-16-14

alainm23 commented 5 years ago

I'm not sure if this is the best way to do it. And according to the elementary style guide, the minimize button is unnecessary. If the player is working in the background and is not shown in Plank, you can make Byte appear using the sound indicator.

redian23 commented 5 years ago

Good. It's just offer to do. /--/--/ I find bug, in wingpanel don't switch play/stop button. today did try fix him in MediaKey.vala, but i could not. (are you have a telegram account? PM me @restorm on TG) Screenshot from 2019-09-19 16-28-03 Screenshot from 2019-09-19 16-28-09

alainm23 commented 5 years ago

Yes, I also see the error. I will try to fix it. I'm sorry, I don't use Telegram.

redian23 commented 5 years ago

t's a pity! close Pull_rec if anything i will write you on Gmail.