search

ellie-idb / blocklandjs

BlocklandJS - a implementation of V8 in Blockland. Bad code included.
2 stars 0 forks source link

Fix not getting method fields #26

Closed McTwist closed 6 years ago

McTwist commented 6 years ago

Currently getting static and dynamic fields works, but there's a third field called method fields. To get this one need to tag into the SimObject to get correct values: https://github.com/hatf0/tge151/blob/9c6ff74f1949b3a2479e66577ae0acdf1b83d240/engine/console/consoleObject.h#L577 https://github.com/hatf0/tge151/blob/9c6ff74f1949b3a2479e66577ae0acdf1b83d240/engine/console/simBase.cc#L787 However, as FieldList is actually a template Vector<T>, it means it'll take much more work to make it attach to the engine properly.

Visolator commented 6 years ago

Yeah he is currently aware of the issue due to my attempts, but thank you for making a possible solution.

McTwist commented 6 years ago

I left it here for future reference as I didn't bother finding a possible fix for it. Will eventually pick it up in the future whenever we find an another way around it.

ellie-idb commented 6 years ago

One way to approach this is through the same approach that the DSO reader internally handles it. https://github.com/hatf0/tge151/blob/master/engine/console/compiledEval.cc#L807