search

ellie-idb / blocklandjs

BlocklandJS - a implementation of V8 in Blockland. Bad code included.
2 stars 0 forks source link

Value retrieval is not thread-safe #27

Closed ellie-idb closed 6 years ago

ellie-idb commented 6 years ago

This will lead into incorrect/odd results being thrown all around in Torque with very, very, very high performance objects. As a fix, I suggest we implement our own value retrieval system (using the mFieldDictionary + finding the internal Vector for member values..).

McTwist commented 6 years ago

You still need to attach to TS to make sure it does not change any values you read from.