search

elliot-sawyer / silverstripe-linkfield

Adds a Linkfield for gorriecoe/silverstripe-link
BSD 3-Clause "New" or "Revised" License
9 stars 25 forks source link

Update composer.json #13

Closed jules0x closed 4 years ago

jules0x commented 5 years ago

silvershop/hasonefield 3.0.2 has a necessary visibility change to a static in a test.

elliot-sawyer commented 5 years ago

3.0.2 seems to have broken the hasonefield for a few people. I'd like to wait until that issue is resolved before merging this.

wernerkrauss commented 4 years ago

@elliot-sawyer this was fixed in https://github.com/silvershop/silverstripe-hasonefield/pull/44 could you please check and update the hasonefield dependency?

elliot-sawyer commented 4 years ago

Thanks @wernerkrauss I'll try to have a look this weekend.

elliot-sawyer commented 4 years ago

@jules0x and @wernerkrauss I've bumped the module up to hasonefield 3.0.4 and a quick test indicates that it works. Do either of you want to check out my fork and confirm before I merge? Details over on #15

elliot-sawyer commented 4 years ago

I've merged this in https://github.com/gorriecoe/silverstripe-linkfield/pull/15