search

elliot-sawyer / silverstripe-linkfield

Adds a Linkfield for gorriecoe/silverstripe-link
BSD 3-Clause "New" or "Revised" License
9 stars 25 forks source link

HasOneField is locked to 3.0.1? #19

Closed mlewis-everley closed 4 years ago

mlewis-everley commented 4 years ago

My project just updated this module to 1.0.0 and it downgraded HasOneField to 3.0.1 (was previously set as ~3.0).

This causes a warning to be flagged:

[Warning] filemtime(): stat failed for .../vendor/silvershop/silverstripe-hasonefield/templates/SilverStripe/Forms/GridField/GridFieldAddNewButton.ss

I believe this was a but in 3.0.1 and has been fixed in later versions. Is there a reason for locking this module to 3.0.1? It seemed to be working fine for me with later versions.

elliot-sawyer commented 4 years ago

There was an error with the upstream hasonefield module that's been fixed and merged: https://github.com/gorriecoe/silverstripe-linkfield/issues/14. I think it's just awaiting a tag, which seems to have slipped through the cracks.

elliot-sawyer commented 4 years ago

1.0.1 is tagged, so composer should pull in the latest version now

mlewis-everley commented 4 years ago

Cool, seems to be working now, cheers!