[Delete Command] Issue with Filtering when Input Name Matches Multiple Contacts

[elliot-tang]

Actual Output

When the Full Name passed into the Delete Command matches multiple users, the filtered list shown includes contacts which don't match the Full Name passed in.

Expected Output

Since the Delete Command requires the full name to match, the resultant list should only include users whose full name exactly matches the input name.

Steps to Reproduce

1. Add two users with the same name, e.g. "John Doe"
2. Add another user, e.g. "Jack Doe"
3. Input the command delete John Doe

Screenshots

Suggested Improvement

Modify the filter algorithm to only filter contacts which match the full name and exclude partial matches (e.g. one of the words passed in matches a part of the contact's name)

[nus-pe-script]

Team's Response

This is the intended behavior. If there are no duplicates, John Doe would be deleted. If there are duplicates, the list is filtered, considering each space separated word as a search keyword. This is why Jack Doe is also displayed.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: Thank you for your reply.

In my opinion however, the intended behaviour is not well outlined in the User Guide, and hence there is still a discrepancy between the documented behaviour and the actual behaviour.

To substantiate this, I refer to the following lines from the User Guide, which explicitly states:

• Deletes the person with the specified NAME
• Only delete if NAME is exact match with contact full name
• If more than 1 exact match, list will be filtered based on given NAME

To me, given that the delete command mandates exact matches, the list of filtered contacts should only include contacts who have an exact match.

However, the actual behaviour includes unrelated contacts which do not match exactly the input NAME, which could confuse users who expect the application to only show exact matches. Furthermore, this could diminish the usefulness of the product, since there might be many more partial matches than exact matches. (for example, if the contact list includes many people with the same surname, as is extremely common in Singapore and other parts of the world).

An example of this can be found in the original report, which I reiterate here for ease of reference:

Steps to reproduce:

1. Add two users with the same name, e.g. "John Doe"
2. Add another user, e.g. "Jack Doe"
3. Input the command delete John Doe

To me, this discrepancy between the advertised behaviour and actual behaviour is grounds for a type.FunctionalityBug of severity.Low. I do not feel that this warrants a rejection.

---