Some code base improvements (slight speed increase included)

elliotblackburn / mdpdf

Markdown to PDF command line app with support for stylesheets

https://npmjs.com/package/mdpdf

Apache License 2.0

717 stars 47 forks source link

Some code base improvements (slight speed increase included) #119

Closed nopeless closed 2 years ago

nopeless commented 2 years ago

This PR includes #118

Notes:

Fix callback chain
Use the default tab instead of a new page

elliotblackburn commented 2 years ago

Hi @nopeless thanks for this, I've been meaning to move towards async and await for a while now so this will be a nice step in the right direction.

Would it be possible to rebase your branch with master and fix the conflict? I think it's been caused by your previous PR which I merged and that this is based on. If you're able to do that I can run the tests and get this merged!

elliotblackburn commented 2 years ago

To save you some time and since I have a moment between some tasks I've gone ahead and done the rebase. I've squashed the changes together and merged them into master at https://github.com/BlueHatbRit/mdpdf/commit/e5b183428aa04ae5c83eeb08ce635621de891946 🎊 🚀

Thanks so much for your contributions!!