search

elliotblackburn / mdpdf

Markdown to PDF command line app with support for stylesheets
https://npmjs.com/package/mdpdf
Apache License 2.0
717 stars 47 forks source link

change install to ci and respect package-lock #124

Closed nopeless closed 2 years ago

nopeless commented 2 years ago

You should use npm ci instead of npm install for ci

elliotblackburn commented 2 years ago

Thanks, this seems like a sensible change. Would it be possible to re-push your branch with just the ci change? It looks like you caught another change which is already in an existing PR I think. It would be great to merge this one quickly 😄

elliotblackburn commented 2 years ago

Now that we've merged the concurrent file piece I can merge this one in. To save you rebasing I've pulled the branch and done it manually due to a squash merge on the previous PR. Your ci change is now on master :)

nopeless commented 2 years ago

Now that we've merged the concurrent file piece I can merge this one in. To save you rebasing I've pulled the branch and done it manually due to a squash merge on the previous PR. Your ci change is now on master :)

Oops, yeah I should have pulled master and synced first. my b