elliotchance / concise

✅ Concise is test framework for using plain English and minimal code, built on PHPUnit.
MIT License
45 stars 3 forks source link

Calculating progress bar incorrectly #282

Closed elliotchance closed 9 years ago

elliotchance commented 9 years ago

AbstractResultPrinter.php


    /**
     * @return integer
     */
    public function getFinishedCount()
    {
        return $this->getSuccessCount() + $this->getSkippedCount() +
        $this->getIncompleteCount() + $this->getRiskyCount();
    }

DefaultResultPrinter.php

    protected function drawProgressBar()
    {
        $progressBar = new ProportionalProgressBar();

        return $progressBar->renderProportional(
            $this->width,
            $this->getTotalTestCount(),
            array(
                'green' => $this->getFinishedCount(),
                'yellow' => $this->getIncompleteCount() +
                    $this->getRiskyCount(),
                'blue' => $this->getSkippedCount(),
                'red' => $this->getFailureCount() + $this->getErrorCount(),
            )
        ) . "\n";
    }
elliotchance commented 9 years ago

Cannot reproduce.