search

elliotchance / concise

✅ Concise is test framework for using plain English and minimal code, built on PHPUnit.
MIT License
45 stars 3 forks source link

Pho integration #283

Closed elliotchance closed 8 years ago

elliotchance commented 8 years ago

Using describe, context and it.

Review on Reviewable

elliotchance commented 8 years ago

The assertions are not being counted.

elliotchance commented 8 years ago

Reviewed 4 of 28 files at r1, 1 of 22 files at r2, 2 of 10 files at r3, 17 of 20 files at r4, 1 of 1 files at r5. Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from the review on Reviewable.io

elliotchance commented 8 years ago

Review status: 0 of 38 files reviewed at latest revision, 3 unresolved discussions.

_src/Concise/Extensions/Pho/PhoTestSuite.php, line 163 [r4] (raw file):_ Done.

Comments from the review on Reviewable.io

elliotchance commented 8 years ago

Review status: 0 of 38 files reviewed at latest revision, 3 unresolved discussions.

src/Concise/Extensions/Pho/PhoTestSuiteLoader.php, line 32 [r4] (raw file): Done.

_src/Concise/Extensions/Pho/ProxySuite.php, line 15 [r4] (raw file):_ I've added a test case for this.

Comments from the review on Reviewable.io

elliotchance commented 8 years ago

Reviewed 3 of 29 files at r6, 10 of 12 files at r7, 25 of 25 files at r8. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

elliotchance commented 8 years ago

Reviewed 2 of 3 files at r9. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io