elliotchance / concise

✅ Concise is test framework for using plain English and minimal code, built on PHPUnit.
MIT License
45 stars 3 forks source link

Add support for PHP 7 #328

Closed elliotchance closed 7 years ago

elliotchance commented 8 years ago

Review on Reviewable

elliotchance commented 8 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

ostrolucky commented 7 years ago

@elliotchance Is PHP7 support still missing? I wanted to try concise since it looks interesting, but I'm not going to do even that since this project looks pretty much dead :( Is there a recommended alternative? Maybe https://github.com/atoum/atoum?

elliotchance commented 7 years ago

Hi @ostrolucky - it's true I haven't put any new features into concise for a while. But it's still heavily used by the company I work for. We simply haven't upgraded to PHP7 yet.

I have a feeling I know why those couple of tests are failing, I'll investigate now.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.0009%) to 99.668% when pulling 07dd5c66fb5c2f6da6a9ac0db35ad47965f1b70b on 2.2.0/328-php7 into bdea3b15d8ec0890362545db5ad3b17f5e92259e on release/2.2.0.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.0007%) to 99.668% when pulling 746e486a2aa554587032c717f65d1d3f3506e308 on 2.2.0/328-php7 into facad98a4ca034b515625a0d01a19de5fc222edf on release/2.2.0.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.0007%) to 99.668% when pulling 746e486a2aa554587032c717f65d1d3f3506e308 on 2.2.0/328-php7 into facad98a4ca034b515625a0d01a19de5fc222edf on release/2.2.0.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8fd1d4d2617b7dbb8f3977c60126f553fe0e8e69 on 2.2.0/328-php7 into 445c82060871663b197ddf51a90a5add1c6efe68 on release/2.1.2.

elliotchance commented 7 years ago

Reviewed 1 of 1 files at r2, 1 of 1 files at r4. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

elliotchance commented 7 years ago

@ostrolucky this has been merged and released as v2.1.2.