Closed okdana closed 7 years ago
Thanks @okdana, I had not considered this. I have marked it as a bug since it may effect users in the scenario you provide.
I am a big fan of DRY code so it makes sense that the common logic would be moved to an even higher precedence bootstrap - but in this case I think either would be acceptable so I will leave the decision up to you.
If you have time it would be great to get a PR so I can do a patch release. :)
Submitted PR #335. I tried to match your existing code style and everything, let me know if there are any problems though
At the top of
bin/concise
is the following:Because unqualified include paths are relative to the current working directory, this means you can only run
concise
from the parent directory of thevendor
folder. Attempting to run it from elsewhere will fail:To fix this you could have it resolve like this, which is similar to how PHPUnit does it:
This way you can run it no matter what the current working directory is.
I would just submit a PR for this but it requires adding the same code to both
concise
andconcise-init
, so i wanted to get your thoughts on how you'd want to address that in a DRY way. I think the typical thing would be to add asrc/bootstrap.php
that handles auto-loader resolution.