elliotchance / concise

✅ Concise is test framework for using plain English and minimal code, built on PHPUnit.
MIT License
45 stars 3 forks source link

Bad formatting on jenkins CI printing #339

Open rcwsr opened 8 years ago

rcwsr commented 8 years ago

Hi,

I just tried out concise on a jenkins build. It is probably a configuration issue my end, but running concise --ci on jenkins doesn't print like it does in the console.

When there are no errors, the progress isn't updated (whereas phpunit's dot printer will update the output)

concise1

When there are errors, the formatting is wrong:

[exec] 
[exec] 19. Acme\ControllerTest::testOrderDir with data set #4
[exec] 
[exec]     Failed asserting that 500 matches expected 200.
[exec]     
[exec]     tests/phpunit/Acme\ControllerTest.php
[exec]         Line 154: PHPUnit_Framework_Assert::assertEquals()
[exec]     (unknown file)
[exec]         Line ?: Acme\ControllerTest->testOrderDir()
[exec]     
[exec] 
elliotchance commented 8 years ago

Thanks, that is a bug - all colours should be removed from the output when under --ci mode.

I have only tested concise for CI against Travis which is able to translate the terminal colours into real colours in the output - hidden in plain sight you may say :)