search

elliotchance / concise

✅ Concise is test framework for using plain English and minimal code, built on PHPUnit.
MIT License
45 stars 3 forks source link

Fix for COMPOSER_VENDOR_DIR #346

Closed elliotchance closed 5 years ago

elliotchance commented 7 years ago

This change is Reviewable

elliotchance commented 7 years ago

@willemstuursma, this fixed #345 - please review

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4a43fb30402932c77bb821be88d252f74cd79922 on 2.1.2/345-vendor-path into 445c82060871663b197ddf51a90a5add1c6efe68 on release/2.1.2.

willemstuursma commented 7 years ago

@elliotchance This doesn't work for me. The VENDOR_DIR environment variable is only set when installing with Composer, not when running Concise.

It all seems a bit elaborate for just displaying the version number.

Something like:

    public function findVendorFolder($path = null)
    {
        return dirname(dirname(dirname(dirname(dirname(__FILE___)))));
    }

Might just be sufficient.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ded6dd6f03b91e92a48d14b0c35f1fa8f06992be on 2.1.2/345-vendor-path into 314302e2d1a555fd9c451449ea79947797665654 on release/2.1.x.

elliotchance commented 5 years ago

@willemstuursma I'm closing this because it has been stale for too long. Let me know if you want to revisit it.