search

elliotchance / gedcom

👪 A Go library and CLI tools for encoding, decoding, traversing, merging, comparing, querying and publishing GEDCOM files.
MIT License
96 stars 21 forks source link

HTML: Fix panic on nil Component #265

Closed elliotchance closed 5 years ago

elliotchance commented 5 years ago

A nasty little bug where the nil check on a set of components was not correctly identifying a nil Component.

This change is Reviewable

codecov-io commented 5 years ago

Codecov Report

Merging #265 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   64.65%   64.65%           
=======================================
  Files         204      204           
  Lines        6538     6538           
=======================================
  Hits         4227     4227           
  Misses       2185     2185           
  Partials      126      126
Impacted Files Coverage Δ
html/core/components.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd434cc...b3a9430. Read the comment docs.