search

elliotchance / gedcom

👪 A Go library and CLI tools for encoding, decoding, traversing, merging, comparing, querying and publishing GEDCOM files.
MIT License
96 stars 21 forks source link

Publish: Better handling of index letters #267

Closed elliotchance closed 5 years ago

elliotchance commented 5 years ago

Index letters (on the Individuals) page will now not show up if there are no living individuals for that index letter.

This also fixes a bug where the sources were not being published.

This change is Reviewable

codecov-io commented 5 years ago

Codecov Report

Merging #267 into master will increase coverage by 0.31%. The diff coverage is 71.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage    65.5%   65.81%   +0.31%     
==========================================
  Files         207      207              
  Lines        6636     6644       +8     
==========================================
+ Hits         4347     4373      +26     
+ Misses       2156     2139      -17     
+ Partials      133      132       -1
Impacted Files Coverage Δ
document.go 78.41% <ø> (ø) :arrow_up:
html/individual_list_page.go 9.83% <0%> (ø) :arrow_up:
html/publish_header.go 0% <0%> (ø) :arrow_up:
html/individuals.go 100% <100%> (ø) :arrow_up:
html/publish.go 78.04% <100%> (+11.38%) :arrow_up:
html/util.go 48.54% <50%> (+4.85%) :arrow_up:
html/individual_index_header.go 52.77% <65.21%> (+7.95%) :arrow_up:
html/source_list_page.go 31.25% <0%> (+31.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51dc917...e12a161. Read the comment docs.