Try to improve performances - Githubissues

elliotchance / orderedmap

🔃 An ordered map in Go with amortized O(1) for Set, Get, Delete and Len.

MIT License

817 stars 62 forks source link

Try to improve performances #30

Closed MagnaboscoL closed 1 year ago

MagnaboscoL commented 1 year ago

This PR tries to improve the performances without altering the API of the package.

The main improvements are:

avoid allocating an Element when iterating using (Element).Next() and (Element).Prev()
avoid allocating an Element when calling (OrderedMap).Front() and (OrderedMap).Back()
avoid computing the length of the doubly linked list since it is not strictly needed

I guess this PR somehow addresses the concerns expressed in https://github.com/elliotchance/orderedmap/issues/3 for the v2 version. benckmarks_pre_PR.txt benckmarks_post_PR.txt: after commit 1743bc4 benckmarks_post_PR_non_circular_list.txt: after commit 4dccd44

This change is