elliotchance / pie

🍕 Enjoy a slice! A utility library for dealing with slices and maps that focuses on type safety and performance.
https://pkg.go.dev/github.com/elliotchance/pie/v2
MIT License
1.96k stars 91 forks source link

add `int32s` and `int64s` and `uint32` and `uint64` and `float32` #177

Open Luoxin opened 2 years ago

elliotchance commented 2 years ago

Thanks for contributing, but I don't think I want to accept this change since it adds a lot of bloat to pie v1 and I would encourage anyone to upgrade to pie v2. Is there a reason that prevents you from using Go 1.18+?

Luoxin commented 2 years ago

The business upgrade to the GO version was not as fast because some internal calls using the system layer crashed after the upgrade to 1.18.  Maybe v2 and V1 should be supported at the same time

elliotchance commented 2 years ago

I do not want all this extra generated code to be committed for less common types. You can use pie to generate the types for your project.